support react 18 #1020
Merged
support react 18 #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 51 57 +6
Branches 6 5 -1
=========================================
+ Hits 51 57 +6
Continue to review full report at Codecov.
|
InfiniteXyy
force-pushed
the
feat/react-18
branch
from
d9d6954 to
f31d107
Compare
InfiniteXyy
force-pushed
the
feat/react-18
branch
from
f31d107 to
5c4a0ee
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1019.
In React 18, external state management may not work due to
concurrentmode. To sync state, we have to use theuseSyncExternalStorehook.Luckily, React officially provides a lib, https://www.npmjs.com/package/use-sync-external-store, to ship support for both React 17 and 18.
In this PR, I installed that hook, and made some refactoring to compat the
use-sync-external-storeAPI. All the test cases and ts defination have not been changed.